-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Board emu rework #10
Merged
Merged
Board emu rework #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Daft-Freak
commented
Sep 6, 2023
- No more --picosystem-sdk
- "hires" mode works for picosystem sdk things
- Can run DaftBoy... which is definitely a very reasonable thing to do
- Probably easier to add more "boards"
- Less DMA hacks
- More PIO... hacks
- Fixed buttons for picosystem sdk (though also kinda broken over there Fix GPIO init pimoroni/picosystem#97)
Slightly less stubby than the memorybus hacks
Makes log less noisy
With a hack to constantly empty it so that we don't hang
Hopefully to make my high-level hacks less hacky... and not in the core
Causes more sync problems than it solves
Otherwise every read/write is going to happen on the first cycle
Slightly more work as commands/data go through the same program
There are pullups on the board and the ps sdk doesn't enable the internal ones (due to a bug)
Removes a picosystem-sdk check
Default to values used by the picosystem sdk as we don't handle the writes from there yet (no SPI support)
Should be the last user of the flag
Leave enough to override board type and tell the user to do that instead
Will need this for some more PIO hacks
Really need to be a lot more strict about syncing bus masters... but this is an improvement
Definitely can't be stalled if the FIFO isn't empty
Sometimes we get out of sync and the FIFO is stuck full...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.